Repository navigation
conformance: add the hierarchy and sets groups - #1287
Draft
justinhwang wants to merge 1 commit into
Draft
justinhwang wants to merge 1 commit into
justinhwang wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 5, 2026
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 5, 2026 18:50
499ee9e to
b98d0ee
Compare
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 5, 2026 19:32
b98d0ee to
de5160a
Compare
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 5, 2026 22:38
de5160a to
646c709
Compare
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 6, 2026 16:54
646c709 to
9e7a011
Compare
isaacbrodsky
force-pushed
the
conformance-3-hierarchy
branch
from
November 8, 2026 16:33
9e7a011 to
999dcdb
Compare
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 9, 2026 14:22
999dcdb to
851f570
Compare
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 9, 2026 15:39
851f570 to
945aaca
Compare
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 19, 2026 17:51
945aaca to
cf7db6b
Compare
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 19, 2026 18:09
cf7db6b to
6633eae
Compare
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 19, 2026 18:11
6633eae to
01afccc
Compare
Adds the record files and runners for the hierarchy functions: cellToParent at every coarser resolution, cellToCenterChild and cellToChildren one resolution finer, cellToChildPos with the childPosToCell round trip; and compactCells and uncompactCells over six kinds of input set per subject, including duplicates, invalid cells and resolution mismatches, with the uncompact-of-compact round trip. The curated files hold the cellToChildren fixtures, the compact and multipolygon input files and the res 0 cells. The files are the generator's output and are byte-identical to the ones generated in h3-go from v4.5.0 at seed 20260929. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
justinhwang
force-pushed
the
conformance-3-hierarchy
branch
from
November 19, 2026 18:40
01afccc to
6473a87
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the record files and runners for the hierarchy and set functions.
Part of the conformance suite stack (#1285 → #1286 → #1287 → #1288 → #1289 → #1290); the specification is
dev-docs/conformance.md.Functions covered
cellToParentat every coarser resolution,cellToCenterChildandcellToChildrenone resolution finer,cellToChildPoswith thechildPosToCellround trip.compactCellsanduncompactCellsover six kinds of input set per subject (the children two levels down, a 2-disk, a 3-disk with holes, a child set with a duplicate, a 1-disk plus an invalid cell, a 1-disk uncompacted to a coarser resolution), with the uncompact-of-compact round trip.Files
hierarchy/cells.jsonlhierarchy/curated.jsonlsets/sets.jsonlsets/curated.jsonlThe curated files hold the
cellToChildrenfixtures, the compact and multipolygon input files and the res 0 cells. Runners:testConformanceHierarchy,testConformanceSets.The committed files are byte-identical to the ones generated in h3-go from v4.6.0 at seed 20260929.
🤖 Generated with Claude Code
Stack created with GitHub Stacks CLI • Give Feedback 💬