Skip to content

conformance: add the hierarchy and sets groups - #1287

Draft
justinhwang wants to merge 1 commit into
conformance-2-traversalfrom
conformance-3-hierarchy
Draft

justinhwang wants to merge 1 commit into
conformance-2-traversalfrom
conformance-3-hierarchy

Conversation

@justinhwang

@justinhwang justinhwang commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the record files and runners for the hierarchy and set functions.

Part of the conformance suite stack (#1285 → #1286 → #1287 → #1288 → #1289 → #1290); the specification is dev-docs/conformance.md.

Functions covered

  • cellToParent at every coarser resolution, cellToCenterChild and cellToChildren one resolution finer, cellToChildPos with the childPosToCell round trip.
  • compactCells and uncompactCells over six kinds of input set per subject (the children two levels down, a 2-disk, a 3-disk with holes, a child set with a duplicate, a 1-disk plus an invalid cell, a 1-disk uncompacted to a coarser resolution), with the uncompact-of-compact round trip.

Files

File Rows
hierarchy/cells.jsonl 781
hierarchy/curated.jsonl 8
sets/sets.jsonl 1,344
sets/curated.jsonl 6

The curated files hold the cellToChildren fixtures, the compact and multipolygon input files and the res 0 cells. Runners: testConformanceHierarchy, testConformanceSets.

The committed files are byte-identical to the ones generated in h3-go from v4.6.0 at seed 20260929.

🤖 Generated with Claude Code


Stack created with GitHub Stacks CLI • Give Feedback 💬

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coveralls

coveralls commented Nov 5, 2026 •

Copy link
Copy Markdown

Coverage Status

Coverage is 99.687% — conformance-3-hierarchy into conformance-2-traversal. No base build found for conformance-2-traversal.

@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from b98d0ee to de5160a Compare November 5, 2026 19:32
@justinhwang
justinhwang removed this pull request from stack #1291 November 5, 2026 22:38
@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from de5160a to 646c709 Compare November 5, 2026 22:38
@justinhwang
justinhwang added this pull request to stack #1295 November 5, 2026 22:38
@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from 646c709 to 9e7a011 Compare November 6, 2026 16:54
@isaacbrodsky
isaacbrodsky force-pushed the conformance-3-hierarchy branch from 9e7a011 to 999dcdb Compare November 8, 2026 16:33
@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from 999dcdb to 851f570 Compare November 9, 2026 14:22
@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from 851f570 to 945aaca Compare November 9, 2026 15:39
@justinhwang justinhwang changed the title Add the hierarchy and sets conformance groups conformance: add the hierarchy and sets groups Nov 12, 2026
@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from 945aaca to cf7db6b Compare November 19, 2026 17:51
@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from cf7db6b to 6633eae Compare November 19, 2026 18:09
@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from 6633eae to 01afccc Compare November 19, 2026 18:11
Adds the record files and runners for the hierarchy functions:
cellToParent at every coarser resolution, cellToCenterChild and
cellToChildren one resolution finer, cellToChildPos with the childPosToCell
round trip; and compactCells and uncompactCells over six kinds of input
set per subject, including duplicates, invalid cells and resolution
mismatches, with the uncompact-of-compact round trip. The curated files
hold the cellToChildren fixtures, the compact and multipolygon input files
and the res 0 cells.

The files are the generator's output and are byte-identical to the ones
generated in h3-go from v4.5.0 at seed 20260929.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@justinhwang
justinhwang force-pushed the conformance-3-hierarchy branch from 01afccc to 6473a87 Compare November 19, 2026 18:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants